Conversation
|
@weizhouapache @shwstppr @rhtyd please let me know if this needs to go on 4.15. as it is only an intergration test skipping, I didn't deeem it important. |
|
@DaanHoogland there seems some issue with one of the test - test_02_migrate_VM_with_two_data_disks. I found it failing on Ubuntu18 as well, I'll check if I can fix that |
@DaanHoogland To be honest, I suspect the failures are caused by some changes in code, not infrastructure/os side. |
|
@DaanHoogland I checked the result of pr #4582 which are good. Strange I cannot find some test cases in test/integration/smoke/test_vm_life_cycle.py and its history !! the test cases in result for pr #4531 are same as what we see in test/integration/smoke/test_vm_life_cycle.py |
| self.skipTest("Requires at least two hosts for performing migration related tests") | ||
|
|
||
|
|
||
| for host in self.hosts: |
There was a problem hiding this comment.
@DaanHoogland it seems not be a CentOS issue, but issue with test scripts or libvrt/kvm plugin.
let's skip the live migration with volume on kvm at first, so trillian test for other prs is good.
we can fix the issue afterwards. it needs investigation.
could you change the lines to skip the test by checking the host hypervisor instead of host os ?
There was a problem hiding this comment.
I could, but since the tests are for KVM only anyway, that would effectively mean disabling the tests completely.
|
@DaanHoogland can you change the base to 4.15? The issue also affects PRs targeting 4.15 branch |
|
Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 311 |
|
Trillian test result (tid-335)
|
|
@blueorangutan package |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 319 |
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress. |
|
Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 339 |
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
Trillian test result (tid-364)
|
|
@DaanHoogland looks like a |
|
Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 343 |
|
@rhtyd a py3 print statement was in the way. taken it out. |
|
Packaging result: ✔️ centos7 ✔️ centos8 ✔️ debian. SL-JID 348 |
|
@blueorangutan test |
|
@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
@blueorangutan test centos8 kvm-centos8 |
|
@davidjumani a Trillian-Jenkins test job (centos8 mgmt + kvm-centos8) has been kicked to run smoke tests |
|
@blueorangutan test ubuntu18 kvm-ubuntu18 |
|
@davidjumani unsupported parameters provided. Supported mgmt server os are: |
|
@blueorangutan test ubuntu18 kvm-ubuntu18 |
|
@davidjumani a Trillian-Jenkins test job (ubuntu18 mgmt + kvm-ubuntu18) has been kicked to run smoke tests |
|
Trillian test result (tid-375)
|
|
Trillian test result (tid-376)
|
|
Trillian test result (tid-374)
|
|
@DaanHoogland @davidjumani cc @andrijapanicsb @alexandremattioli - should we consider switching to qemu-kvm-ev in our environment and update cloudstack docs if the default CentOS7 packages don't work? See: Otherwise, I propose we check if these test fail with CentOS8 too? If not, let make the skip/check code more granular to check CentOS distro and version, based on which we should skip the test(s). |
|
@rhtyd I'd like to agree, but having alternative packages for qemu/libvirt would mean that we either cannot install in an isolated environment or we have to package that code with ACS. Neither has my preference. I'd say document it and let it slide/known issue. |
|
No, we want to keep the old behaviour of SKIPPING these, David knows the root cause why these are now run, by mistake (previously were "overriden" not to run). No custom packages pls. |
|
Merging this based on last test run on centos7, tests do get skipped for CentOS7; and Wei's testing as well as my lgtm. |
|
@davidjumani for any further fixes for Ubuntu or Trillian, submit separate PRs, thanks. |
8 participants
Description
This PR skips live migration on centos as the default installations for qemu/libvirt don't support it.
Fixes #4757
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?